Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] inject otel context #83

Merged
merged 9 commits into from
Jan 6, 2025
Merged

[Feature] inject otel context #83

merged 9 commits into from
Jan 6, 2025

Conversation

yotamloe
Copy link
Collaborator

@yotamloe yotamloe commented Dec 31, 2024 •
edited
Loading

Description

What type of PR is this?

(check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build / CI
  • ⏩ Revert

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help from somebody

@yotamloe yotamloe requested review from ralongit and 8naama December 31, 2024 08:52
8naama
8naama reviewed Jan 2, 2025
View reviewed changes
Copy link
Contributor

@8naama 8naama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! 🔥

Left small comment; Also, in the readme, I think we can merge with #74 PR to update the referenced versions in the requirements

pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
@yotamloe yotamloe requested a review from 8naama January 5, 2025 05:42
8naama
8naama approved these changes Jan 5, 2025
View reviewed changes
Copy link
Contributor

@8naama 8naama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing 🎉

Just need to update the readme dependency but code looks good!

@yotamloe yotamloe merged commit 2c20dfa into master Jan 6, 2025
12 checks passed
@yotamloe yotamloe deleted the feature/inject-otel-context branch January 6, 2025 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@8naama 8naama 8naama approved these changes

@ralongit ralongit Awaiting requested review from ralongit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yotamloe @8naama